Re: [PATCH] ModemManager: Change length input to gsm7 to take the number of characters rather than octets

From: Nathan Williams <njw google com>
To: Dan Williams <dcbw redhat com>
Cc: networkmanager-list gnome org
Subject: Re: [PATCH] ModemManager: Change length input to gsm7 to take the number of characters rather than octets
Date: Fri, 8 Apr 2011 12:00:11 -0400

Sure, updated patch attached.

- Nathan

On Thu, Apr 7, 2011 at 6:45 PM, Dan Williams <dcbw redhat com> wrote:

On Thu, 2011-04-07 at 18:09 -0400, Nathan Williams wrote:
> As it says in the patch, this is necessary to distinguish between 7-
> and 8-character messages, since both are encoded in 7 octets.

Can you fix up the testcases too?

src/tests/test_unpack_gsm7: **
ERROR:test-charsets.c:103:test_unpack_gsm7: assertion failed (unpacked_len == sizeof (expected)): (11 == 12)

Dan

Attachment: mm-patch-gsm7-2
Description: Binary data

Follow-Ups:
- Re: [PATCH] ModemManager: Change length input to gsm7 to take the number of characters rather than octets
  - From: Dan Williams

References:
- [PATCH] ModemManager: Change length input to gsm7 to take the number of characters rather than octets
  - From: Nathan Williams
- Re: [PATCH] ModemManager: Change length input to gsm7 to take the number of characters rather than octets
  - From: Dan Williams

[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]