Re: [PATCH] ModemManager: Change length input to gsm7 to take the number of characters rather than octets
- From: Dan Williams <dcbw redhat com>
- To: Nathan Williams <njw google com>
- Cc: networkmanager-list gnome org
- Subject: Re: [PATCH] ModemManager: Change length input to gsm7 to take the number of characters rather than octets
- Date: Thu, 14 Apr 2011 13:31:06 -0500
On Fri, 2011-04-08 at 12:00 -0400, Nathan Williams wrote:
> Sure, updated patch attached.
Pushed, thanks.
Dan
>
> - Nathan
>
> On Thu, Apr 7, 2011 at 6:45 PM, Dan Williams <dcbw redhat com> wrote:
> On Thu, 2011-04-07 at 18:09 -0400, Nathan Williams wrote:
> > As it says in the patch, this is necessary to distinguish
> between 7-
> > and 8-character messages, since both are encoded in 7
> octets.
>
>
> Can you fix up the testcases too?
>
> src/tests/test_unpack_gsm7: **
> ERROR:test-charsets.c:103:test_unpack_gsm7: assertion failed
> (unpacked_len == sizeof (expected)): (11 == 12)
>
> Dan
>
>
>
>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]