Re: [PATCH] ModemManager: Change length input to gsm7 to take the number of characters rather than octets
- From: Dan Williams <dcbw redhat com>
- To: Nathan Williams <njw google com>
- Cc: networkmanager-list gnome org
- Subject: Re: [PATCH] ModemManager: Change length input to gsm7 to take the number of characters rather than octets
- Date: Thu, 07 Apr 2011 17:46:21 -0500
On Thu, 2011-04-07 at 17:45 -0500, Dan Williams wrote:
> On Thu, 2011-04-07 at 18:09 -0400, Nathan Williams wrote:
> > As it says in the patch, this is necessary to distinguish between 7-
> > and 8-character messages, since both are encoded in 7 octets.
>
> Can you fix up the testcases too?
>
> src/tests/test_unpack_gsm7: **
> ERROR:test-charsets.c:103:test_unpack_gsm7: assertion failed (unpacked_len == sizeof (expected)): (11 == 12)
You should be able to run 'make check' and reproduce the issue if you've
configured with --with-tests=yes.
Dan
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]