Re: Fix for wrong handling of cid variable in mm-generic-gsm.c connect()

[Maciej Grela <maciej grela gmail com>]

2010/11/2 Dan Williams <dcbw redhat com>:
> On Sun, 2010-10-31 at 12:08 +0200, Maciej Grela wrote:
>> Hi,
>>
>> I have recently noticed, that my Nokia E51 stopped working in
>> NetworkManager. In mm debug I saw the following message:
>
> Hmm, did you give an APN in the config before connecting?  If not, then
> I think there's a few things we should do to handle that case better.
> The patch is still clearly correct; though it would cause the code to
> dial ATD*99***0#, which is invalid.  If the phone accepts that, it's
> wrong.  I think what we should end up doing when there's no APN is just
> dialing ATD*99# and let the modem decide, possibly screwing the user in
> the process when the modem's stored APN is wrong.
>

I don't have an APN set in the config, so the cid == -1 and with the
patch mm dials 'ATD*99#'. So this works correctly IMHO. The '*99#' is
a 'fallback' number called when the APN is unknown and thus cid cannot
be selected.

> (APNs are stored in the *modem*, not the SIM, so if you ever change
> providers and put in a different SIM, ATD*99# is guaranteed not to work)
>

I didn't know that, thanks for explanation.

Best regards,
Maciej Grela

PS. The ICCID read fails for my sim, can this be a problem ? See below:

** (modem-manager:8763): DEBUG: <1288810506.760960> (ttyACM0): -->
'AT+CRSM=176,12258,0,0,10<CR>'
** (modem-manager:8763): DEBUG: <1288810506.888854> (ttyACM0): <--
'<CR><LF>ERROR<CR><LF>'
** (modem-manager:8763): DEBUG: Got failure code 100: Unknown error