Re: NM does not completely handle default route



On Tuesday 13 October 2009 17:05:56 Dan Williams wrote:
> On Sun, 2009-10-11 at 22:44 +0200, Robert Vogelgesang wrote:
> > On Sun, Oct 11, 2009 at 03:12:05PM -0400, Gene Czarcinski wrote:
> > > See the attached patch in another email.  My choice of parameter/option
> > > is NM_NEVER_DEFAULT= for devices/NICs/connections that should never be
> > > the default route.
> >
> > [...]
> >
> > > The code/logic change to use NM_ALLOWDEFAULT= rather than what I used
> > > (NM_NEVER_DEFAULT_=) should be minor if that is preferred.
> >
> > I don't really care either if it'll be NEVERDEFAULT or ALLOWDEFAULT.
> >
> > But why be so humble and prefix this option with "NM_"?  I'd rather avoid
> > anything that could keep others (i. e. system-config-network and the
> > networking init scripts) from using this option/concept; they could
> > benefit from this as well.  ;-)
> 
> In the name of consistency, the Fedora PPP code has "DEFROUTE=no|yes"
> which we should probably re-use for this instead of NM_NEVER_DEFAULT.
> The mapping there is pretty clear.
> 
> NM should also honor GATEWAYDEV if it's set, but never try to write it
> back out.  On write-out we should simply set DEFROUTE=no in the
> connection's ifcfg.
> 
> Gene, care to respin the patch with DEFROUTE?

Patch re-spun and added the BZ report: 
https://bugzilla.redhat.com/show_bug.cgi?id=528281

Naturally, never-default is still used internally and in the 
~.gconf/system/networking xml files.  This also means that never-default has 
the opposite value from DEFROUTE ... never-default=true when DEFROUTE=no

As I point out in the BZ report, this patch has been applied to "current" 
src.rpm for both F11 and F12-rawhide ... no changes needed.

I still have a little reservation about using DEFROUTE.  While DEFROUTE=no 
clearly means that a connection must not be used for the default route, 
DEFROUTE=yes means that the connection could be used as the default route but 
not necessarily ... consider a system with three NICs.

Dan ... With this patch applied and if initscripts is updated (per your BZ 
report), that only leaves system-config-network.  That is, shouldn't it also 
support DEFROUTE= ?

Gene


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]