Re: Bug in src/nm-gsm-device.c

[Dan Williams <dcbw redhat com>]

On Wed, 2009-05-20 at 10:23 +0200, Pablo Martí Gamboa wrote:
> Hi all,
> 
> I've just been bitten by a small bug in src/nm-gsm-device.c +443:
> 
> const char *responses[] = { "+CREG: 0,0", "+CREG: 0,1", "+CREG: 0,2",
> "+CREG: 0,3", "+CREG: 0,5", NULL };
> 
> 
> If an external implementation has send '+CREG=1' those terminators
> won't work. I think that you should just check the last part of the
> +CREG response.

What would the response & terminator look like in that case?  Not quite
sure I follow.

> Tambet said that this file is no longer present in "trunk", although
> I'm following fdo's git and its indeed there, wtf?

Its there, but I don't think it's actually tracked by git, and it's nto
actually part of the dist tarball.  So when you switch between branches,
it'll get left over.  Probably some git-fu we dont' understand, since
nm-cdma-device.c doesnt' get left around.  I honestly don't know.

Dan

> Best regards,
> 
> -- 
> Pablo Martí
> http://www.linkedin.com/in/pmarti || http://www.warp.es
> python -c "print '706d6172746940776172702e6573'.decode('hex')"
> 
> _______________________________________________
> NetworkManager-list mailing list
> NetworkManager-list gnome org
> http://mail.gnome.org/mailman/listinfo/networkmanager-list