Fwd: [PATCH] Marked policy file strings for translation

[David Planella <david planella googlemail com>]

Hi,

I sent the forwarded i18n patch a couple of months ago and I
additionally filed a bug [1] on Bugzilla. So far I haven't received
any feedback.

Could anyone review the patch? Thanks.

Regards,
David.

[1] http://bugzilla.gnome.org/show_bug.cgi?id=582918

---------- Forwarded message ----------
From: David Planella <david planella googlemail com>
Date: 2009/5/17
Subject: [PATCH] Marked policy file strings for translation
To: networkmanager-list gnome org


Hi nm hackers,

I'm not sure whether it is necessary to addtionally send this email,
since I've already filed a bug for this (#582918), but since
http://projects.gnome.org/NetworkManager/developers/ recommends patches
to be sent to the list, here it goes:

This patch makes the strings in the policy file translatable.

---
 po/POTFILES.in                                     |    1 +
 policy/Makefile.am                                 |    6 +++-
 ...edesktop.network-manager-settings.system.policy |   21 --------------------
 ...sktop.network-manager-settings.system.policy.in |   21 ++++++++++++++++++++
 4 files changed, 26 insertions(+), 23 deletions(-)
 delete mode 100644
policy/org.freedesktop.network-manager-settings.system.policy
 create mode 100644
policy/org.freedesktop.network-manager-settings.system.policy.in

diff --git a/po/POTFILES.in b/po/POTFILES.in
index 433e752..f3437c8 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -12,4 +12,5 @@ system-settings/plugins/ifcfg-rh/crypto.c
 system-settings/plugins/ifcfg-rh/reader.c
 system-settings/src/main.c
 system-settings/src/nm-default-wired-connection.c
+policy/org.freedesktop.network-manager-settings.system.policy.in

diff --git a/policy/Makefile.am b/policy/Makefile.am
index 69f5d2e..637ed6b 100644
--- a/policy/Makefile.am
+++ b/policy/Makefile.am
@@ -1,7 +1,9 @@
 polkit_policydir = $(datadir)/PolicyKit/policy

-dist_polkit_policy_DATA =                              \
-       org.freedesktop.network-manager-settings.system.policy
+dist_polkit_policy_in_files =
org.freedesktop.network-manager-settings.system.policy.in
+dist_polkit_policy_DATA = $(dist_polkit_policy_in_files:.policy.in=.policy)
+
+ INTLTOOL_POLICY_RULE@

 check:
        for f in $(dist_polkit_policy_DATA); do \
diff --git a/policy/org.freedesktop.network-manager-settings.system.policy
b/policy/org.freedesktop.network-manager-settings.system.policy
deleted file mode 100644
index 1247e20..0000000
--- a/policy/org.freedesktop.network-manager-settings.system.policy
+++ /dev/null
@@ -1,21 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!DOCTYPE policyconfig PUBLIC
- "-//freedesktop//DTD PolicyKit Policy Configuration 1.0//EN"
- "http://www.freedesktop.org/standards/PolicyKit/1.0/policyconfig.dtd";>
-
-<policyconfig>
-
-  <vendor>NetworkManager</vendor>
-  <vendor_url>http://www.gnome.org/projects/NetworkManager</vendor_url>
-  <icon_name>nm-icon</icon_name>
-
-  <action id="org.freedesktop.network-manager-settings.system.modify">
-    <description>Modify system connections</description>
-    <message>System policy prevents modification of system settings</message>
-    <defaults>
-      <allow_inactive>no</allow_inactive>
-      <allow_active>auth_admin_keep_always</allow_active>
-    </defaults>
-  </action>
-
-</policyconfig>
diff --git a/policy/org.freedesktop.network-manager-settings.system.policy.in
b/policy/org.freedesktop.network-manager-settings.system.policy.in
new file mode 100644
index 0000000..ca8c14b
--- /dev/null
+++ b/policy/org.freedesktop.network-manager-settings.system.policy.in
@@ -0,0 +1,21 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE policyconfig PUBLIC
+ "-//freedesktop//DTD PolicyKit Policy Configuration 1.0//EN"
+ "http://www.freedesktop.org/standards/PolicyKit/1.0/policyconfig.dtd";>
+
+<policyconfig>
+
+  <vendor>NetworkManager</vendor>
+  <vendor_url>http://www.gnome.org/projects/NetworkManager</vendor_url>
+  <icon_name>nm-icon</icon_name>
+
+  <action id="org.freedesktop.network-manager-settings.system.modify">
+    <_description>Modify system connections</_description>
+    <_message>System policy prevents modification of system settings</_message>
+    <defaults>
+      <allow_inactive>no</allow_inactive>
+      <allow_active>auth_admin_keep_always</allow_active>
+    </defaults>
+  </action>
+
+</policyconfig>
--
1.6.0.4