Re: NetworkManager uses deprecated termio instead of termios

[Oliver Falk <oliver linux-kernel at>]

Dan Williams schrieb:
> On Thu, 2009-04-16 at 09:35 +0200, Oliver Falk wrote:
> > Hi list!
> >
> > For reference: https://bugzilla.redhat.com/show_bug.cgi?id=464760
> >
> > While trying to compile NM-1:0.7.0-0.11.svn4022.2 on alpha, I ran into a
> > compile error:
> >
> > """
> > nm-serial-device.c: In function 'nm_serial_device_open':
> > nm-serial-device.c:348: error: array subscript is above array bounds
> > nm-serial-device.c:349: error: array subscript is above array bounds
> > """
> >
> > After analysing the problem, I found out that stdbuf is defined as "struct
> > termio". Take a look at termio.h:
> > """
> > [oliver kriek ~]$ cat /usr/include/termio.h
> > /* Compatible <termio.h> for old `struct termio' ioctl interface.
> >     This is obsolete; use the POSIX.1 `struct termios' interface
> >     defined in <termios.h> instead.  */
> >
> > #include <termios.h>
> > #include <sys/ioctl.h>
> > """
> >
> > A simple fix - at least for alpha - is to use "struct termios" instead (I'll
> > include a patch!). However, I have not tested this on x86 or any other 
> > platform - this is up to you! :-)
> >
> >
> > I see a lot of other places where termios is in use, so I guess it 
> > should be safe, to change the last termio as well...
>
> I've seen the RH bug and I'm still thinking about it; the reason it
> didn't hit 0.7.1 was that I didn't want to destabilize that release with
> this change.  We can look at doing that now that 0.7.1 is out and we're
> into 0.7.2.

OK.

Dunno where this function is actually USED. However. I don't run NM 
actively on my (alpha) machines - so I'll likely never hit any bug 
introduced by this change :-)

-of