[PATCH] IFUPDOWN - remove not used interface functions
- From: Alexander Sack <asac canonical com>
- To: NetworkManager List <networkmanager-list gnome org>
- Subject: [PATCH] IFUPDOWN - remove not used interface functions
- Date: Wed, 8 Oct 2008 13:19:34 +0200
Remove implementation for not used NMSystemConfigInterface callback functions
in ifupdown plugin
=== modified file 'ChangeLog'
--- a/ChangeLog 2008-10-06 19:30:59 +0000
+++ b/ChangeLog 2008-10-07 20:40:57 +0000
@@ -1,8 +1,17 @@
+2008-10-07 Alexander Sack <asac ubuntu com>
+
+ Remove implementation for not used NMSystemConfigInterface callback functions
+ in ifupdown plugin
+
+ * system-settings/plugins/ifupdown/plugin.c
+ - (SCPluginIfupdown_unmanaged_devices_changed) removed
+ - (SCPluginIfupdown_connection_added) removed
+
2008-10-06 Dan Williams <dcbw redhat com>
* src/nm-ip4-config.c
src/nm-ip4-config.h
- nm_ip4_config_is_exported -> nm_ip4_config_get_dbus_path
* src/nm-device-interface.c
- (nm_device_interface_init): make 'ip4-config' a boxed property of type
=== modified file 'system-settings/plugins/ifupdown/plugin.c'
--- a/system-settings/plugins/ifupdown/plugin.c 2008-10-06 18:07:03 +0000
+++ b/system-settings/plugins/ifupdown/plugin.c 2008-10-07 20:40:57 +0000
@@ -89,27 +89,18 @@ SCPluginIfupdown_get_connections (NMSyst
/*
* Return a list of HAL UDIs of devices which NetworkManager should not
* manage. Returned list will be freed by the system settings service, and
* each element must be allocated using g_malloc() or its variants.
*/
static GSList*
SCPluginIfupdown_get_unmanaged_devices (NMSystemConfigInterface *config);
-/* Signals */
-
-/* Emitted when a new connection has been found by the plugin */
-static void
-SCPluginIfupdown_connection_added (NMSystemConfigInterface *config,
- NMExportedConnection *connection);
-
-/* Emitted when the list of unmanaged devices changes */
-static void
-SCPluginIfupdown_unmanaged_devices_changed (NMSystemConfigInterface *config);
+/* GObject */
static void
GObject__get_property (GObject *object, guint prop_id,
GValue *value, GParamSpec *pspec);
static void
GObject__set_property (GObject *object, guint prop_id,
const GValue *value, GParamSpec *pspec);
@@ -132,18 +123,16 @@ update_system_hostname(NMInotifyHelper *
static void
system_config_interface_init (NMSystemConfigInterface *system_config_interface_class)
{
system_config_interface_class->init = SCPluginIfupdown_init;
system_config_interface_class->get_connections = SCPluginIfupdown_get_connections;
system_config_interface_class->get_unmanaged_devices = SCPluginIfupdown_get_unmanaged_devices;
- system_config_interface_class->connection_added = SCPluginIfupdown_connection_added;
- system_config_interface_class->unmanaged_devices_changed = SCPluginIfupdown_unmanaged_devices_changed;
}
static void
sc_plugin_ifupdown_class_init (SCPluginIfupdownClass *req_class)
{
GObjectClass *object_class = G_OBJECT_CLASS (req_class);
g_type_class_add_private (req_class, sizeof (SCPluginIfupdownPrivate));
@@ -270,38 +259,16 @@ SCPluginIfupdown_get_connections (NMSyst
*/
static GSList*
SCPluginIfupdown_get_unmanaged_devices (NMSystemConfigInterface *config)
{
// XXX implement this.
return NULL;
}
-/* Signals */
-
-/* Emitted when a new connection has been found by the plugin */
-static void
-SCPluginIfupdown_connection_added (NMSystemConfigInterface *config,
- NMExportedConnection *connection)
-{
- PLUGIN_PRINT("SCPlugin-Ifdown", "connection_added ... started");
- g_return_if_fail (config != NULL);
- g_return_if_fail (NM_IS_CONNECTION (connection));
- PLUGIN_PRINT("SCPlugin-Ifdown", "connection_added ... ended");
-}
-
-/* Emitted when the list of unmanaged devices changes */
-static void
-SCPluginIfupdown_unmanaged_devices_changed (NMSystemConfigInterface *config)
-{
- PLUGIN_PRINT("SCPlugin-Ifdown", "unmanaged_devices_changed ... started");
- g_return_if_fail (config != NULL);
-
- PLUGIN_PRINT("SCPlugin-Ifdown", "unmanaged_devices_changed ... ended");
-}
static const char *
get_hostname (NMSystemConfigInterface *config)
{
SCPluginIfupdownPrivate *priv = SC_PLUGIN_IFUPDOWN_GET_PRIVATE (config);
return priv->hostname;
}
- Alexander
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]