Re: nm-system-settings problem

[Dan Williams <dcbw redhat com>]

On Tue, 2008-05-13 at 15:20 -0400, Gene Czarcinski wrote:
> On Monday 12 May 2008 13:05:26 Bill Nottingham wrote:
> > Dan Williams (dcbw redhat com) said:
> > > > Now, the question is:  What does this change screw up???
> > >
> > > Originally we did monitor /etc/sysconfig/networking/profiles/default
> > > (which is one of the 3 hardlink locations) but many people expect to
> > > change the files in /etc/sysconfig/network-scripts/ instead.  Not
> > > everyone uses system-config-network evidently.
> >
> > Moreover, /etc/sysconfig/network-scripts is defined to be
> > the active location for current configuration - networking/profiles/default
> > isn't actually read by the actual scripts, so it's probably not what
> > NM should be looking at to be in sync.
> 
> First of all, I missed some of the replies to my message because of email 
> filter I do so I just caught these replies.
> 
> If /etc/sysconfig/network/scripts/ is the "correct" main directory, then 
> system-config-network should be "fixed" to also use it as the main directory 
> (I don't see s-c-network going away anytime soon).
> 
> Regardless, the nm-system-settings-hardlinks patch I should work whether 
> NetworkManager's directory is changed or not (at least that is what my 
> testing showed) ... see https://bugzilla.redhat.com/show_bug.cgi?id=444502 
> for the patch.  This fix is a bit crude (at least I think so) but it does 
> seem to work.

You actually do want to match the watch descriptor to the one that we're
saving; the patch (while it works) is essentially a big club when we
need to be a bit more elegant.  The problem is that the watch
descriptors increase as you add new watches, and therefore if I added a
watch to /var/foo/bar that would now trigger the check there, which is
wrong.  But you're on the right path :)

I've fixed this "correctly" upstream.  Turns out that GIO in glib
doesn't handle hardlinks either.  But I've worked around that by doing
parallel watches on ifcfg files themselves (instead of the
network-scripts directory) to catch the hardlink case.  I'll build a new
testing version of NM presently.

Dan