[patch] fix error message



It is probably already fixed in svn, but just in case it isn't...

Up till yesterday, my /var/log/messages was litterally filled with

Jan 14 18:36:58 romarin NetworkManager: <info>  Error getting killswitch power arguments: org.freedesktop.DBus.Error.InvalidArgs - Argument 0 is specified to be of type "uint32", but is actually of type "int32"
Jan 14 18:37:30 romarin last message repeated 5 times
Jan 14 18:38:32 romarin last message repeated 10 times
Jan 14 18:39:34 romarin last message repeated 10 times
Jan 14 18:40:36 romarin last message repeated 10 times
Jan 14 18:41:38 romarin last message repeated 10 times
Jan 14 18:42:40 romarin last message repeated 10 times
Jan 14 18:43:42 romarin last message repeated 10 times
Jan 14 18:44:44 romarin last message repeated 10 times
........

(up to date fedora 7, with the official NM-0.6.5-7 package)

I fixed that little annoyance by recompiling with the following trivial patch

Cheers,

	Éric Brunet
======================= cut here ==================================================
--- NetworkManager-0.6.5/src/NetworkManager.c	2008-01-16 11:12:55.000000000 +0100
+++ NetworkManager-0.6.5/src/NetworkManager.c	2008-01-16 11:14:43.000000000 +0100
@@ -340,7 +340,7 @@
 {
 	DBusError		err;
 	DBusMessage *	reply = NULL;
-	guint32			status;
+	gint32			status;
 
 	g_return_if_fail (pcall != NULL);
 	g_return_if_fail (data != NULL);
@@ -359,7 +359,7 @@
 		goto out;
 	}
 
-	if (!dbus_message_get_args (reply, &err, DBUS_TYPE_UINT32, &status, DBUS_TYPE_INVALID)) {
+	if (!dbus_message_get_args (reply, &err, DBUS_TYPE_INT32, &status, DBUS_TYPE_INVALID)) {
 		nm_info ("Error getting killswitch power arguments: %s - %s", err.name, err.message);
 		dbus_error_free (&err);
 		goto out;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]