Re: [PATCH] NM DBUS api documentation build system

[Dan Williams <dcbw redhat com>]

On Mon, 2008-02-11 at 23:07 +0100, Will Stephenson wrote:
> On Monday 11 February 2008 17:27:53 Dan Williams wrote:
> > On Mon, 2008-02-11 at 17:26 +0100, Will Stephenson wrote:
> > > On Friday 08 February 2008, Dan Williams said:
> > > > So a simple patch to dbus-binding-tool to make it ignore namespaced
> > > > nodes and attributes will allow us to use the TP namespace within the
> > > > existing introspection XML files and avoid the extra step of spec/*.
> > > 
> > > Ack, maybe it does so already - but is the extra spec/* step really worse 
> than 
> > > having all of downstream have to use a patched dbus-binding-tool?
> > 
> > The patch for dbus-glib is the right thing to do anyway; and I don't
> > think there's a really good reason to have the extra step either.  If
> > the fix does get into dbus-glib, we'd just have to rework the spec
> > generation code again, so we might as well do it right the first time
> > IMHO.
> 
> I'm still not quite sure it's good to pass around extended introspection xml.  
> Are you able to you check the python bindings' behaviour?  I'll see what the 
> Qt tools do.

Well, remember that dbus-glib _doesn't_ take the *.xml verbatim and pass
it through the bus.  The *.xml files are processed into a custom syntax
and stuffed into the C code.  You don't really need the property types
for example, because the glib code is able to introspect the property
types directly from the GObject itself.

So I'm not sure why other bindings are relevant here, because none of
the namespaced stuff should ever go over the bus at all.

> > > > If you're still willing to work on this, I'd love a patch that would run
> > > > the XSLT stuff over the introspection/*.xml (feel free to add all.xml to
> > > > introspection/* if you like) and generate the HTML docs.
> > > 
> > > > I don't think it would be to much work to modify the makefile stuff to
> > > > rip out the bits that convert spec/* -> introspection/* and just
> > > > preserve the bits that do introspection/* -> HTML, right?
> > > 
> > > It's trivial - will post a patch shortly.
> 
> Patch attached.

Will review, thanks!

Dan