Re: [PATCH] NM 0.7.0 build error

[João Valverde <backup95 netcabo pt>]

Dan Williams wrote:
> On Tue, 2008-12-16 at 14:20 +0200, Tambet Ingo wrote:
>   
> > On Tue, Dec 16, 2008 at 01:26, João Valverde <backup95 netcabo pt> wrote:
> >     
> > > Tried the freshly released NetworkManager 0.7.0 tarball (Ubuntu Intrepid
> > > i386, stock gcc), I get the following build error:
> > >
> > >
> > > m-netlink-monitor.c
> > > cc1: warnings being treated as errors
> > > nm-netlink-monitor.c: In function 'nm_netlink_monitor_error_handler':
> > > nm-netlink-monitor.c:488: error: format not a string literal and no format
> > > arguments
> > >
> > >
> > > Patch:
> > >
> > > --- NetworkManager-0.7.0/src/nm-netlink-monitor.c 2008-11-25
> > > 16:46:39.000000000 +0000
> > > +++ NetworkManager-0.7.0-1/src/nm-netlink-monitor.c 2008-12-15
> > > 23:04:48.000000000 +0000
> > > @@ -485,7 +485,7 @@ nm_netlink_monitor_error_handler (GIOCha
> > >
> > > socket_error = g_error_new (NM_NETLINK_MONITOR_ERROR,
> > > NM_NETLINK_MONITOR_ERROR_WAITING_FOR_SOCKET_DATA,
> > > - err_msg);
> > > + "%s", err_msg);
> > >       
> > Using g_error_new_literal() would be a better.
> >     
>
> Fixed a week ago in svn/git anyway...
>
> Dan
>
>   
Forgot to check that, sorry.

João Valverde