Re: NetworkManager crash with svn3993

[Dan Williams <dcbw redhat com>]

On Fri, 2008-08-22 at 11:21 -0400, Tom Sutherland wrote:
> (forgot to cc the list)
> 
> ok, I must've missed the compile error when compiling NetworkManager the
> first time:
> 
> cc1: warnings being treated as errors
> nm-dhcp-manager.c: In function ‘garray_to_string’:
> nm-dhcp-manager.c:287: warning: comparison is always false due to
> limited range of data type
> make[3]: *** [libdhcp_manager_la-nm-dhcp-manager.lo] Error 1


Does this help?

Index: src/dhcp-manager/nm-dhcp-manager.c
===================================================================
--- src/dhcp-manager/nm-dhcp-manager.c	(revision 3989)
+++ src/dhcp-manager/nm-dhcp-manager.c	(working copy)
@@ -269,7 +269,7 @@ garray_to_string (GArray *array, const c
 {
 	GString *str;
 	int i;
-	char c;
+	unsigned char c;
 	char *converted = NULL;
 
 	g_return_val_if_fail (array != NULL, NULL);

If so, I'll commit.

Dan

> 
> 
> 
> 
> On Fri, 2008-08-22 at 09:30 -0400, Dan Williams wrote:
> > On Fri, 2008-08-22 at 00:00 -0400, Tom Sutherland wrote:
> > > I checked out NetworkManager 3993 and nm-applet 861, and NetworkManager
> > > quietly crashes after kicking off a dhclient request, and sometimes it
> > > won't connect at all.  nm-applet "disappears" until I restart
> > > NetworkManager.
> > >
> > > If I restart NetworkManager, it attempts to connect to my (wide-open)
> > > WAP, blinks a bit, then disconnects.  I'm running KDE4.1 on Kubuntu
> > > Hardy Heron.
> > >
> > > Any ideas, help? Thanks.
> > >
> > > Here are some of the more interesting looking errors:
> > >
> > >
> > > NetworkManager: symbol lookup error: NetworkManager: undefined symbol:
> > > nm_utils_garray_to_string
> > 
> > That symbol no longer exists in NM nor is it used anywhere in the
> > applet.  Sounds like you're running a NetworkManager binary that's not
> > 3993 against a libnm-glib that is 3993.  Can you verify that you have
> > rebuilt both NM and the applet and installed them in the right prefixes?
> > Might be worthwhile to run a 'make clean' in the NM source tree, then
> > re-build it, and reinstall.
> > 
> > Dan
> > 
> > >
> > > ** (nm-applet:12278): WARNING **: nm_object_get_property: Error getting
> > > 'WirelessHardwareEnabled' for /org/freedesktop/NetworkManager: The name
> > > org.freedesktop.NetworkManager was not provided by any .service files
> > >
> > > ** (nm-applet:12278): WARNING **: Could not retrieve dbus connections:
> > > Launch helper exited with unknown return code 1.
> > > ** Message: NM appeared
> > > ** Message: NM disappeared
> > >
> > > _______________________________________________
> > > NetworkManager-list mailing list
> > > NetworkManager-list gnome org
> > > http://mail.gnome.org/mailman/listinfo/networkmanager-list
> > 
>