Re: [PATCH] pppoe: handle service string empty case
- From: Dan Williams <dcbw redhat com>
- To: Vitja Makarov <vitja makarov gmail com>
- Cc: network manager <networkmanager-list gnome org>
- Subject: Re: [PATCH] pppoe: handle service string empty case
- Date: Fri, 04 Apr 2008 16:10:54 -0400
On Sat, 2008-04-05 at 00:06 +0400, Vitja Makarov wrote:
> 2008/4/4, Dan Williams <dcbw redhat com>:
> > On Tue, 2008-04-01 at 22:56 +0400, Vitja Makarov wrote:
> > > rp-pppoe could be started with empty service string, this fixes the case.
> > Ah, interesting. What I've done instead is to make an empty service
> > fail validation of the setting. I'm curious where that empty service is
> > coming from, since it shouldn't be written into the setting in the first
> > place... Do you have an empty 'service' item in GConf perhaps?
> > Dan
> Just a case we should handle it
With the commit I've done NM will actually reject the connection; what
should be happening here is that the applet shouldn't be sending that in
the first place. The client should be validating the individual
settings themselves and ensuring that the connection doesn't get sent to
NM if it's invalid. So I'd like to track down where this is leaking
through the applet actually.
] [Thread Prev