Re: [PATCH] pppoe: handle service string empty case

[Dan Williams <dcbw redhat com>]

On Tue, 2008-04-01 at 22:56 +0400, Vitja Makarov wrote:
> rp-pppoe could be started with empty service string, this fixes the case.

Ah, interesting.  What I've done instead is to make an empty service
fail validation of the setting.  I'm curious where that empty service is
coming from, since it shouldn't be written into the setting in the first
place...  Do you have an empty 'service' item in GConf perhaps?

Dan

> Index: src/ppp-manager/nm-ppp-manager.c
> ===================================================================
> --- src/ppp-manager/nm-ppp-manager.c	(revision 3521)
> +++ src/ppp-manager/nm-ppp-manager.c	(working copy)
> @@ -509,7 +509,7 @@
>  		nm_cmd_line_add_string (cmd, dev_str);
>  		g_free (dev_str);
> 
> -		if (pppoe->service) {
> +		if (pppoe->service && *pppoe->service) {
>  			nm_cmd_line_add_string (cmd, "rp_pppoe_service");
>  			nm_cmd_line_add_string (cmd, pppoe->service);
>  		}
> _______________________________________________
> NetworkManager-list mailing list
> NetworkManager-list gnome org
> http://mail.gnome.org/mailman/listinfo/networkmanager-list