Re: [PATCH] pppoe: handle service string empty case

["Vitja Makarov" <vitja makarov gmail com>]

2008/4/4, Dan Williams <dcbw redhat com>:
> On Tue, 2008-04-01 at 22:56 +0400, Vitja Makarov wrote:
>  > rp-pppoe could be started with empty service string, this fixes the case.
>
>
> Ah, interesting.  What I've done instead is to make an empty service
>  fail validation of the setting.  I'm curious where that empty service is
>  coming from, since it shouldn't be written into the setting in the first
>  place...  Do you have an empty 'service' item in GConf perhaps?
>
>  Dan
>
>

Just a case we should handle it