Re: openvpn fixes against svn 3140

[Casey Harkins <caseyharkins gmail com>]

Attached is a patch which fixes DNS (and WINS) for openvpn. There was an 
off by one issue when ensuring a DNS server was provided.

Jon Escombe wrote:
> Error in nm-vpn-connection.c / get_secrets_cb(), due to a mandatory 
> check for a secret. Presumably there are no secrets for my "X509 
> Certificates" connection type?

I'll look into it. If your X509 key is not encrypted, the openvpn plugin 
won't ask for a password (from what I can tell). So the question is 
whether NM always expects some secret back, or if the openvpn plugin is 
not telling NM it doesn't need any secret.

> Error in nm-openvpn-service-openvpn-helper.c / main(), due to a 
> mandatory check for "ifconfig_remote" which isn't specified on a TAP 
> connection.

I'll take care of this.

> Also, I'm not getting a route added for the VPN subnet.

Are you talking about the "Only use VPN connection for these addresses" 
option, or it's not setting your default route to your TAP device?


-casey

Index: vpn-daemons/openvpn/src/nm-openvpn-service-openvpn-helper.c
===================================================================
--- vpn-daemons/openvpn/src/nm-openvpn-service-openvpn-helper.c	(revision 3140)
+++ vpn-daemons/openvpn/src/nm-openvpn-service-openvpn-helper.c	(working copy)
@@ -166,7 +166,7 @@
 
 	g_strfreev (split);
 
-	if (!value_array && array->len > 1) {
+	if (!value_array && array->len > 0) {
 		value_array = g_slice_new0 (GValue);
 		g_value_init (value_array, DBUS_TYPE_G_UINT_ARRAY);
 		g_value_set_boxed (value_array, array);