Re: rt2x00/rt2500 support

[Dan Williams <dcbw redhat com>]

On Wed, 2006-07-12 at 16:33 +0200, Jiri Benc wrote:
> On Wed, 12 Jul 2006 10:09:32 -0400, Dan Williams wrote:
> > Can you run "tree /sys", tar up and compress that output, and send it to
> > me?  I'd like to see how the d80211 devices present themselves in sysfs.
> 
> The interesting part is under /sys/class/ieee80211/ and
> /sys/class/net/*/. Dan, feel free to ask me any questions about it.
> Suggestions are welcomed as well; I don't know what is useful for
> NetworkManager.

Hmm, ok.  Does each /sys/class/net/*/device currently exist when using a
d80211-based driver for each actual network device listed by ifconfig
-a/iwconfig?

> > For _each_ actual network interface (as shown with iwconfig or ifconfig
> > -a), you'll need an entry in /sys/class/net/<device name> that contains
> > a "device" link, like so:
> > 
> > |   |-- net
> > |   |   |-- eth0
> > |   |   |   |-- addr_len
> > |   |   |   |-- address
> > |   |   |   |-- broadcast
> > |   |   |   |-- carrier
> > |   |   |   |-- device -> ../../../devices/pci0000:00/0000:00:1e.0/0000:02:01.0
> 
> d80211 interfaces have also 'wiphy' symlink there, pointing to
> appropriate /sys/class/ieee80211/phyX device.
> 
> > So, Jouni/Michael/Jiri; for d80211, how should SET_NETDEV_DEV get called
> > to assign each 'struct net_device' that d80211 creates with the
> > appropriate 'struct device' item so that the right sysfs links show up?
> 
> The driver is responsible for setting it between ieee80211_alloc_hw and
> ieee80211_register_hw call. It has to be fixed in drivers.

Ok; my patch to rt2x00 does that, but it only seems to set the device
link for the master device, not the actual network interfaces,
apparently (I don't have an rt2x00 card, so can't test).  Does HAL need
to be taught about /sys/class/ieee80211/ then as well?

Could you send the output of 'tree /sys' for a d80211 card so I can
understand what the d80211 device structure actually is?

Thanks!
Dan

> There is also a bug in d80211 - that pointer is not copied to other
> d80211 interfaces. I will fix that.
> 
> Thanks for the report,
> 
>  Jiri
>