Re: [Nemiver-list] Changes to loading a core file

["dodji Seketeli" <dodji domain hid>]

Hey,


On 9/18/06, Jonathon Jongsma <jonathon jongsma domain hid> wrote:
> I committed a change to how we load a core file.  I used the new
> 'execute' dialog as a basis, and created a simple dialog for selecting
> the core file and the executable program.  How does the new dialog
> look to you?

Pretty darn good :-)

> One thing that doesn't quite site well with me is that the resulting
> LoadCoreDialog class was basically copied and pasted from
> RunProgramDialog, so there's a lot of code duplication.  I didn't
> bother abstracting out a base dialog class -- do you feel that would
> be worthwhile?

Well, in theory there we shoud factorize that code, yes. But well, I
don't really have any
concerns about that at the moment. That code is pretty small after all.
But if you really feel like you want to factorize it, please, feel free :-)

Oh, btw, you put me as the author of the files
nmv-load-core-dialog.[cc|h]. I guess that's the result of some
copy/paste, but well, that's not true :-) So I changed these two lines
:-).

> (BTW, Dodji, it was very easy to make these changes, so that must mean
> your code is well-designed)

Or, maybe you are just smart .

> A couple other changes I made (let me know if you disagree with any of them):
> - Keyboard accelerator for loading a core file changed from "_Load
> core file" to "Load _core file" since I think 'core' is the
> distinguishing word in that command.

Agreed.

> - Expanded the menu item "Attach..." to "Attach to running program..."
> to better explain what it does.

Sure. I didn't even noticed the change. That must mean it is very
natural now :-).

> - Added a stock ID to "execute" (Gtk::Stock::EXECUTE)

Yeah, I've seen that, nice.

> By the way, recompiling nmv-dbg-perspective.cc takes a really long
> time for me.  Do you think it would be worthwhile to bry to break it
> up somehow so that one little change to this file doesn't require a
> full recompile?

Well, I have the problem with nmv-dbg-perspective.cc and for
nmv-gdb-engine.cc as well.
These files are getting bigger and bigger and I am thinking about
spliting them but I don't know exactly what the different parts will
be for the moment. But yes, we should do something to reduce this
compilation burden.

Cheers,

Dodji.