[Nemiver-list] Changes to loading a core file



I committed a change to how we load a core file.  I used the new
'execute' dialog as a basis, and created a simple dialog for selecting
the core file and the executable program.  How does the new dialog
look to you?

One thing that doesn't quite site well with me is that the resulting
LoadCoreDialog class was basically copied and pasted from
RunProgramDialog, so there's a lot of code duplication.  I didn't
bother abstracting out a base dialog class -- do you feel that would
be worthwhile?

(BTW, Dodji, it was very easy to make these changes, so that must mean
your code is well-designed)

A couple other changes I made (let me know if you disagree with any of them):
- Keyboard accelerator for loading a core file changed from "_Load
core file" to "Load _core file" since I think 'core' is the
distinguishing word in that command.
- Expanded the menu item "Attach..." to "Attach to running program..."
to better explain what it does.
- Added a stock ID to "execute" (Gtk::Stock::EXECUTE)


By the way, recompiling nmv-dbg-perspective.cc takes a really long
time for me.  Do you think it would be worthwhile to bry to break it
up somehow so that one little change to this file doesn't require a
full recompile?

--
jonner




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]