Re: [Nemiver-list] Re: internationalization

["Jonathon Jongsma" <jonathon jongsma domain hid>]

On 9/8/06, dodji Seketeli <dodji domain hid> wrote:
> Hello Jonner,
>
> > Well, here's a first crack at adding i18n support.  (it also contains
> > a few svn:ignore property changes).  I made all of the build
> > infrastructure changes (configure.ac, Makefile.am, po/, etc) and
> > marked a few strings in various files for translation (including the
> > .desktop file).  So it should basically be ready for translations now.
> > If it looks ok to you, I can commit it.  Let me know.
>
> I have applied the patch and it looks okay.
> I just had one little problem. The config.h.in is now empty.

ahh, sorry about that.  I removed that file because I thought it was
all automatically generated.  I don't keep that file under version
control in my other projects.  When I made the changes to configure.ac
for internationalization, I got a lot of changes to config.h.in (not
all related to gettext stuff) so I figured it'd be easier just to not
keep it in svn.

> In my configuration, I need a line "#undef FOO" in config.h.in if I
> want the final config.h to have "#define FOO"  as the result of an
> AC_DEFINE(FOO) being added to configure.ac.
>
> Otherwise, the AC_DEFINE(FOO) just results in a noop. The net effect
> is that I end up with an empty config.h .

hmm.  I wonder if the reason that the AC_DEFINE macros don't work is
because you don't call `autoheader` in the autogen.sh file.  I think
autoheader should create all of these '#undef FOO' lines in
config.h.in automatically so that it should work.   Maybe that's why
it works for me in my other project where I don't keep config.h.in in
version control (since i'm using gnome-autogen.sh, i think autoheader
gets called automatically for me).  I admit that I'm not an expert on
this stuff, though.  I just know enough to get by.

> So I would not ditch that config.h.in, but rather add a "#undef
> GETTEXT_PACKAGE".
> Maybe I am screwing something up here. Please, just let me know.

Does it work for you if you add an autoheader call to autogen.sh?

> That being said, you can just go ahead an commit :-) We will fix
> things that need further fixing, if any.

OK, i've commited it, but without removing config.h.in for now (until
we figure out what the issue is).

--
jonner