Re: Updated undo patch

[Amos Brocco <amos brocco gmail com>]

Hello,
I tried your changes... but I'm not convinced that limiting 
the undo/redo to just one action is good enough (at least for me): if 
I'm doing multiple
operations I might realize that more than just the
 last one was wrong (for example, if I'm organizing my photos, moving 
them from separate folders
in a common folder... a one-level undo is not very forgiving if the user doesn't realize his mistakes as soon as they happen.

Plus, there seems to be a problem...

- Create folder
- Move it to trash (CTRL+DEL)

- Undo Trash
- Redo Trash

... boom! Just "Redo" is available

A.

2012/1/27 Amos Brocco <amos brocco gmail com>

Hello,
I tried your changes... but I'm not convinced that limiting the undo/redo to just one action is good enough (at least for me): if I'm doing multiple
operations I might realize that more than just the last one was wrong (for example, if I'm organizing my photos, moving them from separate folders
in a common folder... a one-level undo is not very forgiving if the user doesn't realize his mistakes as soon as they happen.

Plus, there seems to be a problem...

- Create folder
- Move it to trash (CTRL+DEL)
- Undo Trash
- Redo Trash

... boom! Just "Redo" is available

A.

2012/1/21 Cosimo Cecchi <cosimoc gnome org>

On Thu, 2012-01-19 at 14:02 -0500, Cosimo Cecchi wrote:

> Overall it's looking good anyway; I won't have much time to work on
> this, but I think with some help we could get this merged for 3.4.

Turned out I found time to work on this today, and I basically
implemented what I said in my previous mail and merged this to master :)

Testing and bug reports are appreciated since it's quite a bit of code.
There's a known bug where sometimes the "Redo" menu item looks
insensitive (but it's actually not), but I haven't figured out why it's
happening, might be a GTK bug.

Cheers,
Cosimo