Re: [PATCH] Fix autorun + mounts outside /media



On Wed, 2008-04-16 at 17:20 +0200, Christian Kellner wrote:
> Hey David,
> 
> > > The other patch is for gvfs and is also related to live cd installers.
> > > Our policy, more or less, is that we only want to show mounts
> > > in /media/* and inside $HOME. Currently this is limited to /etc/fstab
> > > only. However, live cd installers typically like to mount partitions to
> > > actually install files on them. So when they do that, we show an icon on
> > > the desktop... which is not exactly ideal. The attached patch ensures we
> > > hide GVolume and GMount objects for mounted file systems outside /media
> > > and $HOME. 
> > 
> > Right, I think that makes sense too.
> > 
> > I've tried the changes and uploaded to ubuntu hardy since they seem to
> > work correctly, I'll post feedback if any new issue is raised but I
> > think that commiting to trunk and gnome-2-22 should be alright
> 
> I had a quick look and I think it makes sense. Please commit them to
> both trunk and gnome-2-22. Thanks again.

Committed to both trunk and gnome-2-22. Thanks!

     David




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]