Re: [PATCH] Fix autorun + mounts outside /media

[Christian Neumair <cneumair gnome org>]

El mié, 16-04-2008 a las 02:05 -0400, David Zeuthen escribió:
> There's currently a really bad bug in Nautilus where we insist on
> autorunning a mount even if Nautilus didn't automount itself. For
> example if I mount something from the command line or another app,
> then
> Nautilus will open a window with the default settings. This also
> happens
> from live cd installers. The attached patch fixes that problem and
> somewhat simplifies the code. Instead of trying to inhibit autorunning
> from all call sites, we simply only allow autorunning from the
> function
> where we do automounting.

I agree, and I like the idea of reversing the inhibiton semantics.

However, I think the patch breaks in one situation:

I intentionally moved autorun inhibition to the mount operation
callbacks, since it may take may take longer than the inhibition/allow
GTimeout to mount a volume.

Therefore, could you please modify the patch to reflect the old
semantics of nautilus_file_operations_mount_volume() /
volume_mount_cb(), just with s^inhibit^allow^?

Maybe you could also remove the unused variables "file" and "l" from
nautilus-autorun.c:should_autorun_mount()?

Otherwise, I am very fine with the patch.

Thanks for working on this issue!

best regards,
 Christian Neumair

-- 
Christian Neumair <cneumair gnome org>
-