Re: [PATCH] Fix autorun + mounts outside /media

[David Zeuthen <david fubar dk>]

On Thu, 2008-04-17 at 20:59 +0200, Christian Neumair wrote:
> I intentionally moved autorun inhibition to the mount operation
> callbacks, since it may take may take longer than the inhibition/allow
> GTimeout to mount a volume.
>
> Therefore, could you please modify the patch to reflect the old
> semantics of nautilus_file_operations_mount_volume() /
> volume_mount_cb(), just with s^inhibit^allow^?

Sorry, I probably should have noted this in the ChangeLog. I changed
that because it was racy; the signal handler for mount_added from the
volume monitor was triggered before the callback saying that mounting
completed. Thinking about it I'm not sure if that's just a gvfs bug, if
it's desired behavior of if we leave it to be undefined. Tricky.

I don't think it's a big deal how it works now since everything is
turned upside down; e.g. it was a lot more important earlier to tag the
volume with being inhibited that it is now saying that we want to
autorun the mount. Either way, we should probably increase the timeout. 

Thoughts?

> Maybe you could also remove the unused variables "file" and "l" from
> nautilus-autorun.c:should_autorun_mount()?

Sure.

> Otherwise, I am very fine with the patch.
> 
> Thanks for working on this issue!

No problem, thanks for reviewing this.

Thanks,
David