Re: [patch] [bug 410113] remove use of eel string truncation

[Christian Persch <chpe gnome org>]

Hi;

Le mardi 24 juillet 2007 à 15:36 +0200, Alexander Larsson a écrit :
> On Tue, 2007-07-24 at 13:24 +0200, Christian Persch wrote:
> > Hi;
> > There is a problem with eel_str_middle_truncate in that is produces
> > invalid UTF-8 (see bug #409271). And anyway nautilus shouldn't truncate
> > the strings arbitrarily like that, but use pango ellipsisation instead,
> > which handles compose characters etc. correctly. Attached patch [ from
> > http://bugzilla.gnome.org/show_bug.cgi?id=410113 ] removes some uses of
> > eel_str_middle_truncate from nautilus; ok to commit ?
> 
> Nice, please commit.

Committed.

> > The remaining uses of eel_str_middle_truncate are harder to get rid of,
> > since they concern the use of potentially long strings embedded into
> > other text (dialogues) and the window title, where we cannot use pango
> > ellipsisation.
> 
> Yeah, that is nasty...

Since fixing the embedded filenames in normal text will require some
pango work (e.g. bug #147608) and ellipsising the window title gtk
and/or window manager work, maybe eel_str_middle_truncate should at
least be fixed not to produce invalid UTF-8...

	Christian