Re: [patch] [bug 410113] remove use of eel string truncation
- From: Alexander Larsson <alexl redhat com>
- To: Christian Persch <chpe gnome org>
- Cc: nautilus-list gnome org
- Subject: Re: [patch] [bug 410113] remove use of eel string truncation
- Date: Tue, 24 Jul 2007 15:36:05 +0200
On Tue, 2007-07-24 at 13:24 +0200, Christian Persch wrote:
> Hi;
> There is a problem with eel_str_middle_truncate in that is produces
> invalid UTF-8 (see bug #409271). And anyway nautilus shouldn't truncate
> the strings arbitrarily like that, but use pango ellipsisation instead,
> which handles compose characters etc. correctly. Attached patch [ from
> http://bugzilla.gnome.org/show_bug.cgi?id=410113 ] removes some uses of
> eel_str_middle_truncate from nautilus; ok to commit ?
Nice, please commit.
> The remaining uses of eel_str_middle_truncate are harder to get rid of,
> since they concern the use of potentially long strings embedded into
> other text (dialogues) and the window title, where we cannot use pango
> ellipsisation.
Yeah, that is nasty...
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]