Re: Nautilus location bar

[Alexander Larsson <alexl redhat com>]

On Thu, 2007-01-04 at 23:33 +0300, Виталий Ищенко wrote:
> В Чтв, 04/01/2007 в 18:52 +0100, Tom Parker пишет:
> > On Thu, 04 Jan 2007 18:53:55 +0300, Виталий  Ищенко <betalb gmail com>
> >  wrote: > I've tried to replace gnome_vfs_make_uri_from_input with >
> >  gnome_vfs_make_uri_from_input_with_dirs(..., >
> >  GNOME_VFS_MAKE_URI_DIR_CURRENT) (only in src/nautilus-location-bar.c)
> > > but it's not suitable for autocomplete feature (whitespaces at the
> >  end) > & it always fallback to $HOME as current directory, so it's a
> >  bad fix. > It seems that g_get_current_dir() always returns $HOME > >
> >  I tried to find similar bug in bugzilla, but failed. If there is any,
> > > I'll add my comment, if not -- create new
> > 
> > This is http://bugzilla.gnome.org/show_bug.cgi?id=321592. I've attached a
> > partial patch a while back, but it also needs an extended version of
> > gnome_vfs_make_uri_from_input_with_trailing_ws (see bug for more details)
> > before any more progress can be made.
> > 
> Thanks
> 
> Few remarks:
> I've debugged GnomeVFS and nautilus a bit, and found, that it is
> functional only for home directory. And when we change directory to some
> other place it stops working, because g_get_current_dir() call in
> gnome_vfs_make_uri_form_input_with_dirs(...) always returns $HOME.
> 
> I've attached my patch (only for location bar -- browser mode)
> 
> IMO relative paths should work not only for file://. But it seems that
> all series of functions gnome_vfs_make_uri_from_input... cope only with
> local paths, so they should be changed first.
> 
> If it's all OK with patch, I will add this functionality to
> nautilus-location-dialog

Really, we should have a function in gnome vfs that you pass the current
uri too so it correctly handles relative uris. Changing the cwd like
that is not threadsafe and quite ugly.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a jaded moralistic master criminal with no name. She's a sharp-shooting 
nymphomaniac college professor with a flame-thrower. They fight crime!