Re: [PATCH] Fix canvas item bounds calculation

On Wed, 2006-02-15 at 21:31 +0100, Martin Wehner wrote:
> I looked into a regression with the icon layout code and this patch
> turns out to be the culprit. It actually breaks the emblem bounds
> calculation: Create two files in the icon view and give both an emblem.
> Then zoom < 100%. There'll be a huge gap between the icons as the emblem
> rectangle gets larger and larger (it's divided by a value < 1 after all)
> as the zoom level decreases.

I've discovered another bug where reloading magically moved the home
icon down into another position. Some debugging revealed that depending
on current the icon position position canvas_position_to_grid_position
either tells me that an icon two or three grid columns wide, which will
make it either fit into the previously perfectly OK two grid columns or
not. This is the case for a size-invariant icon, in my case it's 121 px
wide in both cases, just with different icon base positions. This hints
at a coordinate translation bug between "real" canvas coordinates and
the margins we add.

Christian Neumair <chris gnome-de org>

Attachment: signature.asc
Description: This is a digitally signed message part

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]