Re: [PATCH] Fix canvas item bounds calculation
- From: Martin Wehner <martin wehner gmail com>
- To: Christian Neumair <chris gnome-de org>
- Cc: nautilus-list gnome org
- Subject: Re: [PATCH] Fix canvas item bounds calculation
- Date: Wed, 15 Feb 2006 21:31:35 +0100
On Sat, 2005-11-12 at 13:44 +0100, Christian Neumair wrote:
> The attached patch fixes various glitches, inter alia problems with
> icons drags of icons containing emblems which are not totally inside the
> icon rect, drawing artefacts after moving icons with zoom levels !=
> 100%, and hit box problems with zoom levels != 100%.
I looked into a regression with the icon layout code and this patch
turns out to be the culprit. It actually breaks the emblem bounds
calculation: Create two files in the icon view and give both an emblem.
Then zoom < 100%. There'll be a huge gap between the icons as the emblem
rectangle gets larger and larger (it's divided by a value < 1 after all)
as the zoom level decreases.
I don't think bringing pixels_per_unit into play at that point is right
at all but even if the calculation would be correct, it'd have to go
into update_bounds() too.
We'll have to revert that patch and try to find the real emblem drawing
bug (#104235), its symptoms were just masked by this change.
Martin
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]