Re: [PATCH] Allow to mount/unmount volume from within target URI



On Fri, 2006-02-17 at 15:29 +0100, Christian Neumair wrote:

> > Also, does the src/file-manager/fm-tree-view.c changes do anything but
> > reordering code?
> 
> Correct, it is just reordering.
> I think it is appropriate because in all the other locations the
> volume/drive ops are before the "Properties" item. IIRC there is also a
> bug report on the old behavior where we put it after "Properties". If we
> get this into 2.14, we'll break UI freeze anyway, so I just stuffed it
> into the patch.

It doesn't seem as important as the other change, and its a much larger
UI break (e.g. it would make screenshots  invalid). 

> > Anyway, this looks like a much better approach.
> 
> OK to commit with additional approval?

Sure, if you got release-team approval.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a fast talking guitar-strumming cyborg She's a psychotic thirtysomething 
snake charmer in the wrong place at the wrong time. They fight crime! 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]