Re: [PATCH] Bug 327691 =?windows-1252?Q?=96_URI-bar_location?= =?windows-1252?Q?_persists_after_deletion?=



Alexander Larsson wrote:
On Tue, 2006-12-12 at 23:40 -0800, Gene Z. Ragan wrote:
Why can't you just use the NautilusFile machinery to figure out when a
file is deleted? I.e. Add a monitor and watch the "changed" signal, then
looking at nautilus_file_is_gone().
Here is an improved way to handle the updating of the path bar based on file changed and deletion. In the words of The Dude, my thinking has become very uptight about this matter.
Too many years away from the code.

This patch technically addresses the bug, but the navigation arrows will still be incorrect. I don't see a bug specifically for that issue. It would surprise me if there wasn't one, but
maybe no one has noticed.  I am thinking about that issue now.

It looks kind of limited. You only look at the NautilusFile for the
current path, whereas the bug report is about a button to the right of
the current path (after going up) being deleted.

The way i see it you need to monitor all the files for the buttons to
the right of the active one, otherwise you wouldn't detect them being
deleted.
Yes. I will take a look at refining the code to do that.


Also, if you just connect to the "changed" signal nautilus won't know
you're interested in changes to the file. You have to express interest
in certain attributes about the file using nautilus_file_monitor_add()
It is interesting that this works.  The file must have already been added
to the monitor somewhere else in the code. I am getting the notifications
and am able to respond to them. I will go ahead and call monitor_add though.

Thanks!

Gene




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]