Re: [PATCH] Bug 327691 – URI-bar location persists after deletion

[Alexander Larsson <alexl redhat com>]

On Sun, 2006-12-10 at 02:40 -0800, Gene Z. Ragan wrote:
> Comrades,
> 
> This diff addresses the various state issues created when deleting a directory
> or file.  The navigation arrows, path bar and bookmarks are all adjusted when a
> file is deleted
> 
> I am not totally comfortable with nautilus-window-info having access to data structures that are 
> located in the src directory.  I am not sure if this is an abstraction violation.  I didn't see
> any other interfaces to update the path bar, but maybe I am missing it.  Suggestions are greatly 
> welcomed.

Why can't you just use the NautilusFile machinery to figure out when a
file is deleted? I.e. Add a monitor and watch the "changed" signal, then
looking at nautilus_file_is_gone().

In fact, i think for instance bookmarks already do this, in
libnautilus-private/nautilus-bookmark.c:bookmark_file_changed_callback().

Furthermore, I'm not sure removing the location from the
history/bookmarks is the right thing to do. What if the location is
automounted, or only exists on some machines you log in to. Do you want
it to go away then?

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a scrappy vegetarian vagrant gone bad. She's a provocative winged 
detective operating on the wrong side of the law. They fight crime!