Re: [PATCH] Fix single-click mode list view item activation
- From: Alexander Larsson <alexl redhat com>
- To: Christian Neumair <chris gnome-de org>
- Cc: nautilus-list gnome org
- Subject: Re: [PATCH] Fix single-click mode list view item activation
- Date: Mon, 11 Jul 2005 11:33:08 +0200
On Thu, 2005-07-07 at 20:15 +0200, Christian Neumair wrote:
> Am Mittwoch, den 06.07.2005, 13:16 +0200 schrieb Alexander Larsson:
> > On Mon, 2005-07-04 at 12:19 +0200, Christian Neumair wrote:
> > > From bug 309389 :
> > >
> > > "Steps to reproduce:
> > > 1. Switch to single click mode
> > > 2. Open the / folder in a window
> > > 3. Ctrl+click to highlight a folder
> > > 4. click on the arrow next to the folder or any other folder"
> > >
> > > The folder which belongs to the clicked expander will be activated in addition to its expansion.
> > >
> > > The ignore_button_release is relevant if a selected item is expanded, on expansion of unselected items only the
> > > fm_list_view_did_not_drag stuff.
> > >
> > >  http://bugzilla.gnome.org/show_bug.cgi?id=309389
> > Without looking too deeply into it, the fm_list_view_did_not_drag change
> > looks a bit strange? Can you explain it, and is there perhaps some more
> > obvious way to handle it?
> When the user clicks a row (but not its expander), it is selected. On
> button release, we used to activate the row under the cursor, without
> checking whether the expander was clicked (which is the case if the row
> not selected). Therefore, we check whether the to-be-activated path is
> actually selected before activating it.
I fixed that part in a different way. We really should never ever run
the did_not_drag part if what happened was just an expansion of the row.
Alexander Larsson Red Hat, Inc
alexl redhat com alla lysator liu se
He's a hate-fuelled day-dreaming Green Beret haunted by memories of 'Nam.
She's a blind communist politician who inherited a spooky stately manor from
her late maiden aunt. They fight crime!
] [Thread Prev