Re: [PATCH] Fix single-click mode list view item activation

Am Mittwoch, den 06.07.2005, 13:16 +0200 schrieb Alexander Larsson:
> On Mon, 2005-07-04 at 12:19 +0200, Christian Neumair wrote:
> > From bug 309389 [1]:
> > 
> > "Steps to reproduce:
> > 1. Switch to single click mode
> > 2. Open the / folder in a window
> > 3. Ctrl+click to highlight a folder
> > 4. click on the arrow next to the folder or any other folder"
> > 
> > The folder which belongs to the clicked expander will be activated in addition to its expansion.
> > 
> > The ignore_button_release is relevant if a selected item is expanded, on expansion of unselected items only the 
> > fm_list_view_did_not_drag stuff.
> > 
> > [1]
> Without looking too deeply into it, the fm_list_view_did_not_drag change
> looks a bit strange? Can you explain it, and is there perhaps some more
> obvious way to handle it?

When the user clicks a row (but not its expander), it is selected. On
button release, we used to activate the row under the cursor, without
checking whether the expander was clicked (which is the case if the row
not selected). Therefore, we check whether the to-be-activated path is
actually selected before activating it.

Christian Neumair <chris gnome-de org>

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]