Re: PATCH: bug 76293 and bug 48317

[Alex Larsson <alexl redhat com>]

On 28 Apr 2002, Dave Bordoley wrote:

> On Sun, 2002-04-28 at 16:06, Alex Larsson wrote:
> > This collides with multiple-selection using the keyboard. Also, on my 
> > swedish keyboard the old ones were not impossible to press. Since Gtk+ 2 
> > it's possible to have that sort of accelerators. 
> 
> my comments were based on the bug report so if this not an issue than I
> can revert the change. (however I do think if it's possible to use these
> keys it would be nice since both netscape/mozilla and windows use them,
> shouldn't multiple). The multiple selections problem only appears in the
> icon view though weird. What should i do?

Having goood keyboard nav for icons seems more important, so we can't 
change this. It happens in the list view too, only it only uses up/down 
for obvious reasons. I don't quite understand what you are asking here.

We'll just have to have to old keys. 

> > > 2. Changed short cut key for home cntrl+home cuz calum said so. Kind of
> > > makes sense too.(bug 76293)
> > 
> 
> Once again, this decision was based on calums comments, I'm assuming
> most standard keyboards would have a home key. (am i wrong?)

It should be common enough I guess.
 
> > > 3. changed add bookmark shortcut to ctl+d and edit bookmark shortcut to
> > > ctl+b as specified in the hig. 
> 
> Perhaps we should change duplicate than, since this is a hig
> recommendation. Any suggestions? Just for the sake of asking does
> duplicate need an accelerator, we already have cut and paste
> accelerators?

Duplication of files seems clearly more important than adding bookmarks 
for a file manager. I think we should keep the old keysbindings.

> Do you need me to redo the whole patch or just those parts.

Whole patch.

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a war-weary Jewish cop who knows the secret of the alien invasion. She's 
a manipulative red-headed museum curator with the power to bend men's minds. 
They fight crime!