Re: [Muine] NEW PRERELEASE: 0.8.0pre4

[Jorn Baayen <jbaayen gnome org>]

You convinced me. Base your new patch on 0.8 though, probably much more
up to date than cvs. My brain is so foggy after a few days of Very
intensive hacking. Just a few more comments on your patch.. you probably
dont want to make a call to gconf to get the dirs for every new album,
better cache it, and hook up to a gconf NotifyEvent.

Also, making properties for FakeLength and MinQueryLength seems
overkill. Just two "protected int" fake_length and min_query_length
should do.

Off to get some rest.

Jorn

On Mon, 2005-01-10 at 09:38 +1100, Tom Coleman wrote:
> > Moving Search to AddWindow doesn't seem like a good idea to me, as now
> > with the PotentialItems stuff the list of Albums/Songs will be iterated
> > twice for every search. 
> 
> True, although I think this is more a deficiency in my implementation
> than a deficiency in the design.. now I think about it, I should have
> added something like a IsRelevantItem method that would return say
> album.FitsCriteria (SearchBits) && album.Complete in AddAlbumWindow's
> case, and then I could have called that from search, thus removing the
> need for two iterations over the list. Also that way there would be no
> need for the OnAlbum* (or OnSong*) handlers inside the two either. I can
> code up the changes easily enough and send them to you if you are
> interested 
> 
> > Also, the search limiting stuff is really only
> > relevant for the AddSongWindow.
> 
> Also true, but I figured having the option of doing the same thing for
> AddAlbumWindow was probably sensible.
> 
> Cheers,
> Tom
> 
> _______________________________________________
> muine-list mailing list
> muine-list gnome org
> http://mail.gnome.org/mailman/listinfo/muine-list