Re: [PATCH] filediff: Display offset with tabs expanded in the status bar
- From: Simon Marchi <simon marchi polymtl ca>
- To: Kai Willadsen <kai willadsen gmail com>
- Cc: meld-list <meld-list gnome org>
- Subject: Re: [PATCH] filediff: Display offset with tabs expanded in the status bar
- Date: Tue, 11 Apr 2017 21:58:08 -0400
On 2017-04-11 16:07, Kai Willadsen wrote:
Thanks for taking the time to do this! I think the idea is good, but I
feel like this can be simpler. Because we're using GtkSourceView (and
not just plain GtkTextView), we have the
GtkSource.View.get_visual_column() API, which I think does what you
want.
Thanks for the tip!
Also, I don't personally see the value in showing both the
expanded-tab and the actual character offset. I checked several other
text editors, and all the ones I looked at showed only the visual
column (i.e., with tabs expanded). This would also neatly avoid the
translation issue you pointed out, since the string doesn't need to
change.
I wanted to avoid changing anyone's workflow, but I agree with you. I
don't see the use of the byte offset.
Sending a v2 right now.
Simon
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]