Re: Pep8

[Kai Willadsen <kai willadsen gmail com>]

On 18 October 2015 at 11:34, David Rabel <David Rabel noresoft com> wrote:
> Hi there,
>
> to get to know the workflow as well as the Pep8 standard better, I
> thought about go through all source files and fix stuff that is not
> Pep8-conform.
>
> Would that be OK? Do I have to file a bug on bugzilla for this? Or has
> someone else to do this?
>
> Actually I already started, because it is a good exercise for getting
> used to Pep8-style code. Just tell me if you like me to continue or not. :-)

The problem with PEP8-ing all of the current code is that it adds
noise to our git history. The problem isn't the commits themselves,
but rather the git annotate (i.e., blame) output, which will show the
spurious not-really-a-change commit introduced by PEP8 for any
affected code. This can be particularly annoying in older, large files
(i.e., don't bother trying to fix filediff or dirdiff).

As a general rule, I'll probably accept patches for PEP8ing files
where the changes aren't too big, particularly when the file is
almost-PEP8 already. For some files where the 79 character limit has
already been tossed out the window, I wouldn't bother trying to
reinstate that one just yet.

It's worth mentioning two PEP8 caveats. Firstly, PEP8 allows backslash
continuations for long lines, but we don't use them (by which I
mean... we don't use them *any more*). Secondly, PEP8 allows aligned
hanging indents for continued lines, but I would strongly discourage
this.

cheers,
Kai