Re: New feature

[Kai Willadsen <kai willadsen gmail com>]

On 24 March 2013 12:41, Kai Willadsen <kai willadsen gmail com> wrote:
> On 20 March 2013 08:38, Piotr Piastucki <leech miranda gmail com> wrote:
> > On 02/25/2013 08:48 PM, Kai Willadsen wrote:
> > > You're talking about your suggestion of doing an input split followed
> > > by a double compare? In that case, yes, you should always get the sync
> > > point included.
> > >
> > > I was talking about a different option entirely of simply forcing the
> > > algorithm through that point. Since the result should be almost
> > > identical (bar some heuristic speed-ups maybe?), I think doing
> > > whatever is easiest is the best plan.
> >
> > I am attaching a patch with SyncPointMyersSequenceMatcher class that
> > does the split & merge as described before.
>
> Awesome! I've attached your patch and my follow-ups to bug 362233:
>     https://bugzilla.gnome.org/show_bug.cgi?id=362233
>
> Fundamentally, it works. However, the UI is not in a releasable state.
> We'd need to add:
> * Some indication as to the location of split points
> * A way to clear/reset splits points (they're reset as is, but it's
> not obvious, and you can't actually manually remove them)
> * Some way of setting split points separately; just using the last
> cursor position is really pretty awful

I've now added something for these points, and pushed both Piotr's
backend patch and my UI changes, so this should all appear in 1.7.2.
It's a bit rough, but it seems to work, and any additional features
are... well... they're not likely to happen on the current schedule.

cheers,
Kai