Re: [PATCH] Inline highlighting performance improvements

[Kai Willadsen <kai willadsen gmail com>]

On 21 May 2012 17:55, Piotr Piastucki <leech miranda gmail com> wrote:
> On Sun, May 20, 2012 at 2:38 AM, Kai Willadsen <kai willadsen gmail com>
> wrote:
>>
>>
>> Your performance improvement is pretty fantastic - about 330% faster
>> in my tests. I haven't yet updated my Cython branch to match the new
>> logic, but I'm hoping that it should be possible to squeeze another 2x
>> speed-up out of that based on some previous testing.
>>
>> This is definitely an awesome improvement, so thanks! In fact, if
>> enough people hit it without anything breaking, I think this should
>> get cherry-picked onto a 1.6.x release branch.
>
>
> I am glad I was helpful :)
> Your code looks much better indeed. Actually, I would go a bit further and
> refactor the remaining preprocessing code so that it will be consistent
> regardless of matcher used - see attached patch.

Looks good, thanks. Pushed.

cheers,
Kai