Re: mc-4.6.1-20060912.patch

[Thomas Dickey <dickey his com>]

On Wed, 13 Sep 2006, Pavel Tsekov wrote:

> On Wed, 13 Sep 2006, Thomas Dickey wrote:
>
> > On Wed, 13 Sep 2006, Pavel Tsekov wrote:
> >
> > > On Tue, 12 Sep 2006, Thomas Dickey wrote:
> > >
> > > > A fix for mc - attached.
> > > > This patch makes MC use the mouse when built with ncurses.
> > >
> > >
> > > It already does. Would you elaborate why this is necessary ?
> >
> > Perhaps it does in the CVS version (where can I see that?)
> >
> > I was patching the 4.6.1 version, which does not.
>
> If I am guessing right your patch is against the MC tarball from
> http://www.ibiblio.org/pub/Linux/utils/file/managers/mc/snapshots/.

no, I took a quick look for newer versions, but did not notice the 
snapshot (and did not see a cvsweb site, so I was not sure of the current
development status).  I used the 4.6.1 release which is 23 July 2005.

> That tarball should be based on the CVS state from yesterday - so
> it is pretty much the same as the CVS version. I am building
> MC with ncurses support for quite a while and I haven't seen
> problems with the mouse support.

perhaps you're using gpm.  I use it rarely since it generally interferes 
with X.

A quick check of the snapshot using my configuration shows the same bugs 
that I noticed in the release:

        a) cursor keys are not handled properly using the slang
           configuration when running in screen.  (But see below).

        b) there is no support for mouse using ncurses in xterm (or any
           other terminal supported by ncurses, of course).

I had noticed the mouse problem in 2002 when I sent a patch to Pavel 
Roskin, but had not found time then to fix it.  The problem is still the 
same.  Perhaps it would not be hard to resync my 4.6.1 patch against
your snapshot, but since the packagers I normally deal with are using 
4.6.1, that was where I started.

> Would you, please, exlpain the problem that you're seeing and the
> reasons behind your patch. Does it have something to do with
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=369976 ?

not exactly.  Since I maintain ncurses, I deflect bug reports that are 
incorrectly citing ncurses.  I happened to think about MC this week since 
I noticed some comments via google on one of the newsgroups that indicated 
someone's cursor keys did not work in MC.  That might be the same issue
that I noted above.

--
Thomas E. Dickey
http://invisible-island.net
ftp://invisible-island.net