Re: Comprehensive patch escaping system/open calls in vfs/extfs

[Leonard den Ottolander <leonard den ottolander nl>]

Hi Jakub,

On Sat, 2004-08-21 at 17:02, Jakub Jelinek wrote:
> You missed 3 places in a.in:
>
> --- extfs/a.in        2004-08-21 13:45:50.000000000 +0200
> +++ extfs/a.in        2004-08-21 19:06:15.458358276 +0200
> @@ -36,17 +36,20 @@ SWITCH: for ( $ARGV[0] ) {
>    /mkdir/ && do {
>      shift; shift;
>      exit 1 if scalar(@ARGV) != 1;
> -    system("$mmd $qdisk:/$ARGV[0] >/dev/null");
> +    $qname = quote($ARGV[0]);
> +    system("$mmd $qdisk:/$qname >/dev/null");
>      exit 0; };
>    /rmdir/ && do {
>      shift; shift;
>      exit 1 if scalar(@ARGV) != 1;
> -    system("$mrd $qdisk:/$ARGV[0] >/dev/null");
> +    $qname = quote($ARGV[0]);
> +    system("$mrd $qdisk:/$qname >/dev/null");
>      exit 0; };
>    /rm/ && do {
>      shift; shift;
>      exit 1 if scalar(@ARGV) != 1;
> -    system("$mdel $qdisk:/$ARGV[0] >/dev/null");
> +    $qname = quote($ARGV[0]);
> +    system("$mdel $qdisk:/$qname >/dev/null");
>      exit 0; };
>    /copyout/ && do {
>      shift; shift;

Nope. The value of $ARGV[0] is already known because of the SWITCH.

Leonard.

-- 
mount -t life -o ro /dev/dna /genetic/research