Re: [PATCH] Help Viewer - mouse issues

[Pavel Tsekov <ptsekov gmx net>]

On Wed, 2007-01-03 at 19:19, Grigory Trenin wrote:

> 2) mouse-offbytwo.patch
> Last two lines of the help window (the bottom line and a frame)
> are not mouse-clickable. So the user will not be able to follow
> a link with a mouse, if it is situated at the bottom line.
> And the frame needs to be clickable because it serves a special
> purpose - page scrolling.

This is patch is OK, but there are still problems.
See this:

  create_dlg (0, 0, help_lines + 4, HELP_WINDOW_WIDTH + 4,
                                    ^^^^^^^^^^^^^^^^^^^^^^

HELP_WINDOW_WIDTH already is large enough to hold the dialog
frame. As a resylt if you try to click on the right hand side
of the dialog you dont get any movement. I'd like to fix this
before applying your patch so I can commit both fixes.
Unfortunately removing the "+ 4" part is not enough to properly
fix the problem. It seems like man2hlp is producing output
with line lengths larget than HELP_TEXT_WIDTH which is incorrect
IMO. I'll investigate and let you know what have I found. In
the meantime if you want to help me - you are welcome :)