Re: [PATCH] Help Viewer - mouse issues

[Pavel Tsekov <ptsekov gmx net>]

Hello Grigory,

On Wed, 2007-01-03 at 19:19, Grigory Trenin wrote:

> Here are 3 patches to the mouse issues in the Help Viewer.

[...]
> 3) mouse-linkfollow.patch
> When following a link with a mouse, an extra '\n' is insterted
> at the top of the window (just follow any link with a keyboard,
> then return back, and follow the same link with a mouse,
> and you should see the difference).
[...]

How about fixing help_follow_link() instead ? IMO, this
would be a proper fix if we agree that the leading '\n'
is not desired. The help format documentation says:

  "The hypertext file is a file that may have one or more nodes.
   Each node ends with a ^D character and starts with a bracket,
   then the name of the node and then a closing bracket."

I don't see anything about the newline being part of the
node header and that it needs to be stripped. However,
as you noted above if the keyboard is used to follow a link
the newline is stripped. So, IMO, either the documentation
is buggy and we have to fix it and fix help_follow_link()
too or the key handling code is wrong to assume that it 
has to move beyond the newline. Any thoughts ?