Re: [PATCH] Help Viewer - mouse issues

[Grigory Trenin <gtrenin gmail com>]

Pavel Tsekov wrote:

> This is patch is OK, but there are still problems.
> See this:
>
>  create_dlg (0, 0, help_lines + 4, HELP_WINDOW_WIDTH + 4,
>                                    ^^^^^^^^^^^^^^^^^^^^^^
>
> HELP_WINDOW_WIDTH already is large enough to hold the dialog
> frame. As a resylt if you try to click on the right hand side
> of the dialog you dont get any movement. I'd like to fix this
> before applying your patch so I can commit both fixes.
> Unfortunately removing the "+ 4" part is not enough to properly
> fix the problem. It seems like man2hlp is producing output
> with line lengths larget than HELP_TEXT_WIDTH which is incorrect
> IMO. I'll investigate and let you know what have I found. In
> the meantime if you want to help me - you are welcome :)
>  
There is some preformatted stuff that is not generated by man2hlp -
nodes "GNU GENERAL PUBLIC LICENSE", "How to use help"...
I guess that is the problem - it doesn't fit after removing
that "+ 4" part.

However, that problem can be solved if we increase the mouse area:

-    md = mousedispatch_new (1, 1, help_lines, HELP_WINDOW_WIDTH - 2);
+    md = mousedispatch_new (1, 1, help_lines + 2, HELP_WINDOW_WIDTH + 1);
                                                                ^^^^^^