Re: Quoting of variables in fsusage.m4 and ls-mntd-fs.m4

On Tue, 30 May 2006, Roland Illig wrote:

Pavel Tsekov wrote:
On Mon, 29 May 2006, Roland Illig wrote:

Roland Illig wrote:

The quoting hid one bug that appeared due to one variable being used, which had never been defined before. I think it has been fixed upstream.

It has, and I updated our version of ls-mntd-fs.m4 to the one of coreutils. I also documented that in the ChangeLog. Sorry that it took so long.

What do you think about my suggestion to move your changes in
to acinclude.m4 ?

As a new macro? I don't think it's necessary, because I have added only a few lines, which would blow up the size of the configure script unnecessarily. But if you have some better reasons, please tell me.

I told you already. There is an existing macro in acinclude.m4 - AC_GET_FS_INFO. Move your changes there - and some of the test you introduced for header files and functions are unnecessary since the
code in AC_GET_FS_INFO already checks for that.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]