Re: [patch?] recent ftpfs ERRNOR fix broke uploading

[Pavel Tsekov <ptsekov gmx net>]

On Thu, 2 Feb 2006, Jindrich Makovicka wrote:

> Pavel Tsekov wrote:
> > On Thu, 2 Feb 2006, Pavel Tsekov wrote:
> >
> >
> >>On Wed, 1 Feb 2006, Jindrich Makovicka wrote:
> >>
> >>
> >>>after a fix of wrong ERRNOR usage in ftpfs.c (2006-01-24 ftpfs.c
> >>>(ftpfs_dir_load): Fix a bad ERRNOR call), mc segfaults when I try
> >>>uploading directories recursively. Changing the return value from -1 to
> >>>0 seems to fix the problem.
> >>
> >>I've just uploaded a small tree successfully on a remote ftp server. Right
> >>now I am pushing the whole MC tree onto the same server - I'll let you
> >>know when I am done (so far no crash).
> >
> >
> > I couldn't make it crash :( Can you give some more details ?
>
> Sorry... It actually happens only when uploading to a directory without
> read permissions. In my case, the server was vsftpd with
> anon_world_readable_only=yes so the newly uploaded directories are
> unreadable.

I've commited a patch to fix the issue:

http://cvs.savannah.gnu.org/viewcvs/mc/vfs/ftpfs.c?root=mc&sortby=date&r2=1.189&r1=1.188&diff_format=u

In fact the previous patch which fixed the ERRNOR call uncovered a bug in
MC's ftp handling code.

Jindrich, thanks for the heads up!