Re: [patch?] recent ftpfs ERRNOR fix broke uploading

[Jindrich Makovicka <makovick kmlinux fjfi cvut cz>]

Pavel Tsekov wrote:
> On Thu, 2 Feb 2006, Pavel Tsekov wrote:
> 
> 
>>On Wed, 1 Feb 2006, Jindrich Makovicka wrote:
>>
>>
>>>after a fix of wrong ERRNOR usage in ftpfs.c (2006-01-24 ftpfs.c
>>>(ftpfs_dir_load): Fix a bad ERRNOR call), mc segfaults when I try
>>>uploading directories recursively. Changing the return value from -1 to
>>>0 seems to fix the problem.
>>
>>I've just uploaded a small tree successfully on a remote ftp server. Right
>>now I am pushing the whole MC tree onto the same server - I'll let you
>>know when I am done (so far no crash).
> 
> 
> I couldn't make it crash :( Can you give some more details ?

Sorry... It actually happens only when uploading to a directory without
read permissions. In my case, the server was vsftpd with
anon_world_readable_only=yes so the newly uploaded directories are
unreadable.

Here is the backtrace:

#0  0x080b319b in vfs_s_generate_entry (me=0x80e0e20, name=0x81955bd
"Entries", parent=0x0, mode=135139168)
    at direntry.c:179
#1  0x080b40ae in vfs_s_open (me=0x80e0e20, file=0x0, flags=577,
mode=384) at direntry.c:755
#2  0x080b7768 in mc_open (filename=0x80e0f60 "", flags=577) at vfs.c:342
#3  0x08066563 in copy_file_file (ctx=0x8180928, src_path=0x8194bf0
"/home/henry/build/mc/ftp3/mc/src/CVS/Entries",
    dst_path=0x8195810 "/#ftp:holly/incoming/CVS/Entries",
ask_overwrite=1, progress_count=0xbf9d3958,
    progress_bytes=0xbf9d3950, is_toplevel_file=135139168) at file.c:613
#4  0x0806736c in copy_dir_dir (ctx=0x8180928, s=0x817d4f8
"/home/henry/build/mc/ftp3/mc/src/CVS",
    d=0x818b068 "/#ftp:holly/incoming/CVS", toplevel=1, move_over=0,
delete=0, parent_dirs=0x0,
    progress_count=0xbf9d3958, progress_bytes=0xbf9d3950) at file.c:975
#5  0x08068fcb in panel_operate (source_panel=0x8169298,
operation=OP_COPY, force_single=0) at file.c:1887
#6  0x0805b094 in copy_cmd () at cmd.c:310
#7  0x08099554 in buttonbar_call (bb=0x80e0f60, i=<value optimized out>)
at widget.c:2282
#8  0x080996bd in buttonbar_callback (w=0x818c1f8, msg=WIDGET_HOTKEY,
parm=1005) at widget.c:2304
#9  0x08061821 in dlg_process_event (h=0x81682b0, key=1005,
event=0xbf9d3a34) at dialog.c:614
#10 0x08061a10 in run_dlg (h=0x81682b0) at dialog.c:785
#11 0x0807925d in main (argc=135139168, argv=0xbf9d4bd4) at main.c:1680

Regards,
-- 
Jindrich Makovicka